[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] vl: Fix error location of positional arguments
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 1/8] vl: Fix error location of positional arguments |
Date: |
Tue, 2 Apr 2019 15:01:05 +0200 |
We blame badness in positional arguments on the last option argument:
$ qemu-system-x86_64 -vnc :1 bad.img
qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory
I believe we've done this ever since we reported locations. Fix it to
qemu-system-x86_64: bad.img: Could not open 'bad.img': No such file or
directory
Reported-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index d61d5604e5..24572de0bd 100644
--- a/vl.c
+++ b/vl.c
@@ -3119,6 +3119,7 @@ int main(int argc, char **argv, char **envp)
if (optind >= argc)
break;
if (argv[optind][0] != '-') {
+ loc_set_cmdline(argv, optind, 1);
drive_add(IF_DEFAULT, 0, argv[optind++], HD_OPTS);
} else {
const QEMUOption *popt;
--
2.17.2
- [Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 4/8] Revert "vl: Fix to create migration object before block backends again", Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 5/8] Revert "migration: move only_migratable to MigrationState", Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 2/8] qapi/migration.json: Fix ColoStatus member last_mode's version, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 1/8] vl: Fix error location of positional arguments,
Markus Armbruster <=
- [Qemu-devel] [PULL 7/8] vl: Document dependencies hiding in global and compat props, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 6/8] migration: Support adding migration blockers earlier, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 8/8] accel: Unbreak accelerator fallback, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 3/8] qapi/migration.json: Rename COLOStatus last_mode to last-mode, Markus Armbruster, 2019/04/02
- Re: [Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02, Peter Maydell, 2019/04/02