Re: [Qemu-devel] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
56f3c00ae7 s390-bios: Use control unit type to find bootable devices
c2966e5f5d s390-bios: Support booting from real dasd device
983766a941 s390-bios: Add channel command codes/structs needed for dasd-ipl
611ee8ffd5 s390-bios: Use control unit type to determine boot method
50e3c7ec0a s390-bios: Refactor virtio to run channel programs via cio
e1e4dd2d06 s390-bios: Factor finding boot device out of virtio code path
1545b18713 s390-bios: Extend find_dev() for non-virtio devices
059f0520c8 s390-bios: cio error handling
1ec28c0f96 s390-bios: Support for running format-0/1 channel programs
85d5a7e24e s390-bios: ptr2u32 and u32toptr
2cd731c880 s390-bios: Map low core memory
49c910eb88 s390-bios: Decouple channel i/o logic from virtio
baf28e7a02 s390-bios: Clean up cio.h
edd8b22728 s390-bios: decouple common boot logic from virtio
29a974796f s390-bios: decouple cio setup from virtio
34c790a9b0 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/16 Checking commit 34c790a9b010 (s390 vfio-ccw: Add bootindex property and 
IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#222: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/16 Checking commit 29a974796f76 (s390-bios: decouple cio setup from virtio)
3/16 Checking commit edd8b2272899 (s390-bios: decouple common boot logic from 
virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/16 Checking commit baf28e7a023e (s390-bios: Clean up cio.h)
5/16 Checking commit 49c910eb88a3 (s390-bios: Decouple channel i/o logic from 
virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 5/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/16 Checking commit 2cd731c8806e (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 6/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/16 Checking commit 85d5a7e24ef9 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 7/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/16 Checking commit 1ec28c0f965b (s390-bios: Support for running format-0/1 
channel programs)
9/16 Checking commit 059f0520c805 (s390-bios: cio error handling)
10/16 Checking commit 1545b18713d6 (s390-bios: Extend find_dev() for non-virtio 
devices)
11/16 Checking commit e1e4dd2d06c0 (s390-bios: Factor finding boot device out 
of virtio code path)
12/16 Checking commit 50e3c7ec0a59 (s390-bios: Refactor virtio to run channel 
programs via cio)
WARNING: line over 80 characters
#105: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), 
false) == 0,

WARNING: line over 80 characters
#118: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 
0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/16 Checking commit 611ee8ffd5d1 (s390-bios: Use control unit type to 
determine boot method)
14/16 Checking commit 983766a94135 (s390-bios: Add channel command 
codes/structs needed for dasd-ipl)
15/16 Checking commit c2966e5f5d6b (s390-bios: Support booting from real dasd 
device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 433 lines checked

Patch 15/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/16 Checking commit 56f3c00ae7c6 (s390-bios: Use control unit type to find 
bootable devices)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden