Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

[Pankaj Gupta]

> > > 
> > > So I would put the helper in include/linux/dax.h and have it like:
> > > 
> > > bool daxdev_mapping_supported(struct vm_area_struct *vma,
> 
> Should this be static inline if you're putting it in the header file?

yes. Thanks.

> 
> A comment ought to be added to describe what this predicate function
> does.

Sure, will add a comment describing the function.

> 
> > >                         struct dax_device *dax_dev)
> > > {
> > >   if (!(vma->vm_flags & VM_SYNC))
> > >           return true;
> > >   if (!IS_DAX(file_inode(vma->vm_file)))
> > >           return false;
> > >   return dax_synchronous(dax_dev);
> > > }
> > 
> > Sure. This is much better. I was also not sure what to name the helper
> > function.
> > I will go ahead with this unless 'Dave' & 'Darrick' have anything to add.
> 
> Jan's approach (modulo that one comment) looks good to me.

Sure. Thank you.

Best regards,
Pankaj

> 
> --D
>