[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp
From: |
Eduardo Otubo |
Subject: |
Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp |
Date: |
Fri, 5 Apr 2019 11:01:13 +0200 |
User-agent: |
Mutt/1.8.3+47 (5f034395e53d) (2017-05-23) |
On 04/04/2019 - 22:01:38, Thomas Huth wrote:
> On 04/04/2019 20.39, Helge Deller wrote:
> > All major distributions do support libseccomp version >= 2.3.0, so there
> > is no need to special-case on various architectures any longer.
> >
> > Signed-off-by: Helge Deller <address@hidden>
> >
> > diff --git a/configure b/configure
> > index 1c563a7027..8fe4fc84d8 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2377,36 +2369,16 @@ fi
> > ##########################################
> > # libseccomp check
> >
> > -libseccomp_minver="2.2.0"
> > if test "$seccomp" != "no" ; then
> > - case "$cpu" in
> > - i386|x86_64|mips)
> > - ;;
> > - arm|aarch64)
> > - libseccomp_minver="2.2.3"
> > - ;;
> > - ppc|ppc64|s390x)
> > - libseccomp_minver="2.3.0"
> > - ;;
> > - *)
> > - libseccomp_minver=""
> > - ;;
> > - esac
> > -
> > - if test "$libseccomp_minver" != "" &&
> > - $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
> > + libseccomp_minver="2.3.0"
> > + if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
> > seccomp_cflags="$($pkg_config --cflags libseccomp)"
> > seccomp_libs="$($pkg_config --libs libseccomp)"
> > seccomp="yes"
> > else
> > if test "$seccomp" = "yes" ; then
> > - if test "$libseccomp_minver" != "" ; then
> > - feature_not_found "libseccomp" \
> > - "Install libseccomp devel >= $libseccomp_minver"
> > - else
> > - feature_not_found "libseccomp" \
> > - "libseccomp is not supported for host cpu $cpu"
> > - fi
> > + feature_not_found "libseccomp" \
> > + "Install libseccomp devel >= $libseccomp_minver"
> > fi
> > seccomp="no"
> > fi
>
> Reviewed-by: Thomas Huth <address@hidden>
Acked-by: Eduardo Otubo <address@hidden>
--
Eduardo Otubo
Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp, (continued)