Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

[Philippe Mathieu-Daudé]

On 4/5/19 3:04 PM, Olaf Hering wrote:
> Am Fri, 5 Apr 2019 14:59:16 +0200
> schrieb Philippe Mathieu-Daudé <address@hidden>:
>> On 4/5/19 2:09 PM, Olaf Hering wrote:
>>> Am Fri,  5 Apr 2019 13:55:29 +0200
>>> schrieb Philippe Mathieu-Daudé <address@hidden>:
>>>   
>>>> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom  
>>>
>>> This name is too generic and will conflict with ipxe.git if any of "bios 
>>> seavgabios pxerom" is used for 'make -C roms'.  
>>
>> This is similar to commit c9d18c1c150c84e where you said "it used to
>> work", what is the difference?
> 
> Before there was no need to pass EFIROM= to make, so ipxe.git was happy.
> Now it is required, and ipxe.git gets an unexpected value.
> 
>> IPXE override the EFIROM variable, so there is no change there.
> 
> For me ipxe tries to rm $(type -P EfiRom). Let me double check.

Eh you are right...

$ make -C roms EFIROM=/bin/true clean
[...]
make -C ipxe/src veryclean
make[1]: Entering directory '/home/phil/source/qemu/roms/ipxe/src'
rm -f bin{,-*}/*.* bin{,-*}/.certificate.* bin{,-*}/.certificates.*
bin{,-*}/.private_key.* bin{,-*}/errors bin{,-*}/NIC ./util/zbin
./util/elf2efi32 ./util/elf2efi64 /bin/true ./util/efifatbin
./util/iccfix ./util/einfo TAGS bin{,-*}/symtab
rm: cannot remove '/bin/true': Permission denied
make[1]: *** [Makefile.housekeeping:1564: clean] Error 1

This seems to be a pre-existent IPXE bug:

$ git checkout c9d18c1c150c84e7a976df989ad04ddf01083f46
$ make -C roms EFIROM=/bin/true clean
[...]
rm: cannot remove '/bin/true': Permission denied
make[1]: *** [Makefile.housekeeping:1564: clean] Error 1

>> How can I trigger a SUSE package build with this patch?
> 
> Not so easy without a VM.

Oh, unfortunate :(

> 
> Olaf
>

signature.asc
Description: OpenPGP digital signature