[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] test qgraph.c: Fix segs due to out of scope def
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] test qgraph.c: Fix segs due to out of scope default |
|
Date: |
Sat, 6 Apr 2019 11:52:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 05/04/2019 23.16, Paolo Bonzini wrote:
> On 05/04/19 20:40, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <address@hidden>
>>
>> The test uses the trick:
>> if (!opts) {
>> opts = &(QOSGraph...Options) { };
>> }
>>
>> in a couple of places, however the temporary created
>> by the &() {} goes out of scope at the bottom of the if,
>> and results in a seg or assert when opts-> fields are
>> used (on fedora 30's gcc 9).
>>
>> Fixes: fc281c802022cb3a73a5
>> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
>
> Thomas, can you pick this up?
Sure, queued it to my qtest-next branch now:
https://gitlab.com/huth/qemu/tree/qtest-next
I'll send a PULL request on Monday.
Thomas