Re: [Qemu-devel] [PATCH 0/4] Header cleanups

[Aruna Jayasena]

Ok, thanks

On Tue, Apr 9, 2019 at 10:20 PM, Peter Maydell <address@hidden>
wrote:

> On Tue, 9 Apr 2019 at 17:42, Aruna Jayasena <address@hidden>
> wrote:
> >
> > Yeah this is a stand alone patch.
>
> OK, thanks -- just wanted to check there wasn't a missing
> bit. I think this could go in via the qemu-trivial tree
> so I have cc'd them.
>
> We're in the middle of a release at the moment, but we
> should reopen for development in a couple of weeks. If
> this patch still hasn't gone anywhere by a week or so after
> that then please follow up with a 'ping' to check it hasn't
> been forgotten by accident.
>
> > On Tue, Apr 9, 2019 at 10:10 PM, Peter Maydell <address@hidden>
> wrote:
> >> On Tue, 9 Apr 2019 at 16:58, Aruna Jayasena <address@hidden>
> wrote:
> >> >
> >> > Removed unwanted includes from cpu-common.h
> >> > This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks
> >> >
> >> > Signed-off-by: Aruna Jayasena <address@hidden>
> >> >
> >> > ---
> >> >  include/exec/cpu-common.h | 2 --
> >> >  1 file changed, 2 deletions(-)
> >> >
> >> > diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
> >> > index cef8b88a2a..a3594f3f50 100644
> >> > --- a/include/exec/cpu-common.h
> >> > +++ b/include/exec/cpu-common.h
> >> > @@ -7,8 +7,6 @@
> >> >  #include "exec/hwaddr.h"
> >> >  #endif
> >> >
> >> > -#include "qemu/bswap.h"
> >> > -#include "qemu/queue.h"
> >> >  #include "qemu/fprintf-fn.h"
> >> >
> >>
> >> I was surprised that no .c files are implicitly relying
> >> on these includes, but apparently none are, so we can
> >> safely remove them.
> >>
> >> A couple of notes:
> >>  * this doesn't need to go to qemu-stable as it's just a
> >>    code cleanup
> >>  * did something go wrong with your sending of this patch?
> >>    Its subject is "PATCH 0/4" which would usually indicate
> >>    a cover letter for a four-patch series, but this seems
> >>    to be a stand-alone patch.
> >>
> >> Reviewed-by: Peter Maydell <address@hidden>
>
> thanks
> -- PMM
>
-- 
*Aruna* Jayasena
Embedded Systems and Computer Science Engineering Undergraduate
University of Moratuwa
*✆ **+94719872152 *
✉ <address@hidden> ⌨ <http://archfx.github.io> in
<https://www.linkedin.com/in/arunajayasena/>