[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG tab
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table |
Date: |
Wed, 10 Apr 2019 16:11:58 +0200 |
On Wed, 10 Apr 2019 22:01:53 +0800
Wei Yang <address@hidden> wrote:
> On Wed, Apr 10, 2019 at 11:08:33AM +0200, Igor Mammedov wrote:
> >On Wed, 10 Apr 2019 09:12:31 +0800
> >Wei Yang <address@hidden> wrote:
> >
> >> On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote:
> >> >Dummy table (with signature "QEMU") creation came from original SeaBIOS
> >> >codebase. And QEMU would have to keep it around if there were Q35 machine
> >> >that depended on keeping ACPI tables blob constant size. Luckily there
> >> >were no versioned Q35 machine types before commit:
> >> > (since 2.3) a1666142db acpi-build: make ROMs RAM blocks resizeable
> >> >which obsoleted need to keep ACPI tables blob the same size on
> >> >source/destination.
> >> >
> >>
> >> I am not sure getting the "versioned Q35" correctly. Seems originally
> >> there is
> >> q35-1.4?
> >>
> >> commit bf3caa3dc17552b323cec6831301a22cfc98ecd5
> >> Author: Paolo Bonzini <address@hidden>
> >> Date: Fri Feb 8 14:06:15 2013 +0100
> >>
> >> pc: add compatibility machine types for 1.4
> >>
> >> Adds both pc-i440fx-1.4 and pc-q35-1.4.
> >
> >current upstream has only pc-q35-2.4 as earliest versioned Q35
> >machine type (try to run: qemu-system-x86_64 -M help)
>
> Yes, I see those old type are removed. This means we don't want to support
> those old types, right? Because those old types can't be migrated to latest
> upstream qemu.
Exactly
Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table, Wei Yang, 2019/04/11