Re: [Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc3 is now available

[Peter Maydell]

On Thu, 11 Apr 2019 at 11:03, Andrew Randrianasulu
<address@hidden> wrote:
>
> В сообщении от Thursday 11 April 2019 12:14:45 Peter Maydell написал(а):
> > On Wed, 10 Apr 2019 at 22:51, Andrew Randrianasulu
> > <address@hidden> wrote:
> > >
> > > Please also include this patch in next -rc or final, it fixes 32-bit 
> > > compilation:
> > >
> > > https://patchew.org/QEMU/20190402073018.17747-1-kraxel%40redhat.com/
> > > ([Qemu-devel] [PATCH] curses: fix wchar_t printf warning)
> > >
> > > without it I get
> > >
> > > ui/curses.c: In function 'get_ucs':
> > > ui/curses.c:456:25: error: format '%x' expects argument of type 'unsigned 
> > > int', but argument 3 has type 'wchar_t {aka long int}' [-Werror=format=]
> > >          fprintf(stderr, "Could not convert 0x%02x from WCHAR_T to UCS-2: 
> > > %s\n",
> > >
> >
> > Rats, I'd forgotten about that one. What platform does it fail
> > to compile on, though? I test on 32-bit Linux and Windows compiles,
> > and they work OK.
>
> This is slackware (mix of many versions) + gcc (GCC) 5.5.0.
> Probably, this error will not show up if you don't have ncurses-dev packages,
> so configure will NOT enable curses ui ?

It turns out my 32-bit system has libncurses5-dev but not
libncursesw5-dev, so when we added the widechar requirement
it just stopped building the curses UI. I've now fixed that.
On the other hand, I still don't see the error. I think
my gcc/glibc combo must define wchar_t as 'int' anyway
(this is 32-bit arm).

thanks
-- PMM