[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tci: Add implementation for INDEX_op_ld16u_i64
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] tci: Add implementation for INDEX_op_ld16u_i64 |
|
Date: |
Thu, 11 Apr 2019 05:29:10 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/10/19 9:37 PM, Stefan Weil wrote:
>> Why not use tci_write_reg64, since that is the size of the register you're
>> modifying? Let the zero-extension explicit in the name of the opcode to be
>> reflected in the zero-extension implied by the passing of a uint16_t value
>> to a
>> uint64_t argument.
>
> I think that using tci_write_reg64 would be wrong on 32 bit hosts.
... as would using INDEX_op_ld16u_i64 in the first place.
This is already within #if TCG_TARGET_REG_BITS == 64.
r~