[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities' |
Date: |
Thu, 11 Apr 2019 19:05:16 +0100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Thu, Apr 11, 2019 at 05:59:50PM +0000, Singh, Brijesh wrote:
> There are limited numbers of the SEV guests that can be run concurrently.
> A management applications may need to know this limit so that it can place
> SEV VMs on hosts which have suitable resources available.
>
> Currently, this limit is not exposed to the application. Add a new
> 'sev-max-guest' field in the query-sev-capabilities to provide this
> information.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Eric Blake <address@hidden>
> Cc: Daniel P. Berrangé <address@hidden>
> Cc: Laszlo Ersek <address@hidden>
> Cc: Erik Skultety <address@hidden>
> Signed-off-by: Brijesh Singh <address@hidden>
> ---
> qapi/target.json | 6 ++++--
> target/i386/sev.c | 6 ++++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/target.json b/qapi/target.json
> index 1d4d54b600..b45121d30b 100644
> --- a/qapi/target.json
> +++ b/qapi/target.json
> @@ -183,7 +183,8 @@
A few lines above here you need to document the new field
with (since 4.1) annotation.
> 'data': { 'pdh': 'str',
> 'cert-chain': 'str',
> 'cbitpos': 'int',
> - 'reduced-phys-bits': 'int'},
> + 'reduced-phys-bits': 'int',
> + 'sev-max-guests': 'int'},
> 'if': 'defined(TARGET_I386)' }
>
> ##
> @@ -200,7 +201,8 @@
> #
> # -> { "execute": "query-sev-capabilities" }
> # <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE",
> -# "cbitpos": 47, "reduced-phys-bits": 5}}
> +# "cbitpos": 47, "reduced-phys-bits": 5,
> +# "sev-max-guests" : 15}}
> #
> ##
> { 'command': 'query-sev-capabilities', 'returns': 'SevCapability',
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index cd77f6b5d4..bb0cd79acd 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -488,7 +488,7 @@ sev_get_capabilities(void)
> guchar *pdh_data = NULL;
> guchar *cert_chain_data = NULL;
> size_t pdh_len = 0, cert_chain_len = 0;
> - uint32_t ebx;
> + uint32_t ebx, ecx, edx;
> int fd;
>
> fd = open(DEFAULT_SEV_DEVICE, O_RDWR);
> @@ -507,7 +507,7 @@ sev_get_capabilities(void)
> cap->pdh = g_base64_encode(pdh_data, pdh_len);
> cap->cert_chain = g_base64_encode(cert_chain_data, cert_chain_len);
>
> - host_cpuid(0x8000001F, 0, NULL, &ebx, NULL, NULL);
> + host_cpuid(0x8000001F, 0, NULL, &ebx, &ecx, &edx);
> cap->cbitpos = ebx & 0x3f;
>
> /*
> @@ -516,6 +516,8 @@ sev_get_capabilities(void)
> */
> cap->reduced_phys_bits = 1;
>
> + /* the maximum number of SEV guests that can run simultaneously */
> + cap->sev_max_guests = ecx - edx + 1;
> out:
> g_free(pdh_data);
> g_free(cert_chain_data);
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Singh, Brijesh, 2019/04/11
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities',
Daniel P . Berrangé <=
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Laszlo Ersek, 2019/04/11
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Laszlo Ersek, 2019/04/11
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Singh, Brijesh, 2019/04/11
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Laszlo Ersek, 2019/04/12
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Paolo Bonzini, 2019/04/12
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Erik Skultety, 2019/04/12
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Paolo Bonzini, 2019/04/12
- Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities', Erik Skultety, 2019/04/12