Re: [Qemu-devel] [PATCH] spapr: add splpar hcalls H_JOIN, H_PROD, H_CONFER

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] spapr: add splpar hcalls H_JOIN, H_PROD, H_CONFER
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2f73cb0a80 spapr: add splpar hcalls H_JOIN, H_PROD, H_CONFER

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#28: FILE: hw/ppc/spapr_hcall.c:1074:
+    if (env->msr & (1ULL << MSR_EE))
[...]

ERROR: braces {} are necessary for all arms of this statement
#53: FILE: hw/ppc/spapr_hcall.c:1099:
+    if (target != -1 && !CPU(spapr_find_cpu(target)))
[...]

ERROR: braces {} are necessary for all arms of this statement
#61: FILE: hw/ppc/spapr_hcall.c:1107:
+    if (cpu == spapr_find_cpu(target))
[...]

ERROR: braces {} are necessary for all arms of this statement
#93: FILE: hw/ppc/spapr_hcall.c:1139:
+    if (!cs)
[...]

total: 4 errors, 0 warnings, 96 lines checked

Commit 2f73cb0a80a1 (spapr: add splpar hcalls H_JOIN, H_PROD, H_CONFER) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden