[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.1] roms: assert if max rom size is less th
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH for-4.1] roms: assert if max rom size is less than the used size |
|
Date: |
Fri, 12 Apr 2019 10:04:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 12/04/19 10:02, Stefano Garzarella wrote:
> On Thu, Apr 11, 2019 at 01:28:18PM +0200, Igor Mammedov wrote:
>> It would ensure that we would notice attempt to write beyond
>> the allocated buffer. In case of MemoryRegion backed ROM it's
>> the host buffer and the guest RAM otherwise.
>>
>> assert can be triggered with:
>> dd if=/dev/zero of=/tmp/blob bs=63k count=1
>> qemu-system-x86_64 `for i in {1..33}; do echo -n " -acpitable /tmp/blob";
>> done`
>>
>> Fixes: (a1666142db acpi-build: make ROMs RAM blocks resizeable)
>>
>> Reported-by: Wei Yang <address@hidden>
>> Signed-off-by: Igor Mammedov <address@hidden>
>> ---
>> hw/core/loader.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
> Reviewed-by: Stefano Garzarella <address@hidden>
> Tested-by: Stefano Garzarella <address@hidden>
>
> Thanks,
> Stefano
>
Queued, thanks.
Paolo