Re: [Qemu-devel] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

[Philippe Mathieu-Daudé]

On 4/12/19 5:26 PM, Thomas Huth wrote:
> These machines depend on the deprecated bluetooth subsystem. In case we
> finally decide to remove the bluetooth subsystem, we likely need to
> remove the n800 and n810 machines, too, so mark them now as deprecated.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  hw/arm/nseries.c     | 3 +++
>  qemu-deprecated.texi | 6 ++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
> index 906b7ca22d..66e50b850c 100644
> --- a/hw/arm/nseries.c
> +++ b/hw/arm/nseries.c
> @@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine,
>      struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
>      int sdram_size = binfo->ram_size;
>  
> +    warn_report("The n800 and n810 machines are deprecated. Please use a "
> +                "different Arm machine instead.");
> +

Unrelated to this patch, but can you add a similar warning in
uart_hci_init() to make obvious that the bluetooth subsystem is now
deprecated?

>      s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_type);
>  
>      /* Setup peripherals
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 2219386769..4de7452fac 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -145,6 +145,12 @@ This machine type uses an unmaintained firmware, broken 
> in lots of ways,
>  and unable to start post-2004 operating systems. 40p machine type should be
>  used instead.
>  
> address@hidden n800 and n810 (Arm) (since 4.1)
> +
> +These machines depend on the deprecated bluetooth subsystem. When the
> +bluetooth subsystem will be removed, the n800 and n810 machines will be
> +deleted, too. If possible, use a different Arm board instead.
> +
>  @section Device options
>  
>  @subsection Block device options
>