Re: [Qemu-devel] [PATCH 14/17] qom/cpu: Simplify how CPUClass:cpu_dump_state() prints

[Markus Armbruster]

"Dr. David Alan Gilbert" <address@hidden> writes:

> * Markus Armbruster (address@hidden) wrote:
>> CPUClass method dump_statistics() takes an fprintf()-like callback and
>> a FILE * to pass to it.  Most callers pass fprintf() and stderr.
>> log_cpu_state() passes fprintf() and qemu_log_file.
>> hmp_info_registers() passes monitor_fprintf() and the current monitor
>> cast to FILE *.  monitor_fprintf() casts it right back, and is
>> otherwise identical to monitor_printf().
>> 
>> The callback gets passed around a lot, which is tiresome.  The
>> type-punning around monitor_fprintf() is ugly.
>> 
>> Drop the callback, and call qemu_fprintf() instead.  Also gets rid of
>> the type-punning, since qemu_fprintf() takes NULL instead of the
>> current monitor cast to FILE *.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> <phew long patch>
> Yes, I think so.

Thanks for persevering!

> There seems to be a place which changes hmp_info_local_apic in a plce
> that was changed in an earlier patch which seems a shame, but OK.

Hmm.  I think I can avoid that.

> Reviewed-by: Dr. David Alan Gilbert <address@hidden>

Thanks!