[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 27/41] s390x/tcg: Implement VECTOR ELEMENT RO
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1 27/41] s390x/tcg: Implement VECTOR ELEMENT ROTATE LEFT LOGICAL |
Date: |
Tue, 16 Apr 2019 11:27:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 13.04.19 02:15, Richard Henderson wrote:
> On 4/11/19 12:08 AM, David Hildenbrand wrote:
>> +#define DEF_ROTL(BITS)
>> \
>> +static uint##BITS##_t rotl##BITS(uint##BITS##_t a, uint8_t count)
>> \
>> +{
>> \
>> + count &= BITS - 1;
>> \
>> + return (a << count) | (a >> (BITS - count));
>> \
>> +}
>> +DEF_ROTL(8)
>> +DEF_ROTL(16)
>
> We already have rol8 and rol16 in <qemu/bitops.h> for this.
> Otherwise,
>
Thanks, missed these helpers!
> Reviewed-by: Richard Henderson <address@hidden>
>
> This does point out that I should go ahead and fill out the
> variable shift and rotate patterns in gvec...
>
>
> r~
>
--
Thanks,
David / dhildenb
- Re: [Qemu-devel] [PATCH v1 24/41] s390x/tcg: Implement VECTOR OR, (continued)
- [Qemu-devel] [PATCH v1 22/41] s390x/tcg: Implement VECTOR NOR, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 20/41] s390x/tcg: Implement VECTOR MULTIPLY *, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 19/41] s390x/tcg: Implement VECTOR MULTIPLY AND ADD *, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 27/41] s390x/tcg: Implement VECTOR ELEMENT ROTATE LEFT LOGICAL, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 08/41] s390x/tcg: Implement VECTOR AVERAGE LOGICAL, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 25/41] s390x/tcg: Implement VECTOR OR WITH COMPLEMENT, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 23/41] s390x/tcg: Implement VECTOR NOT EXCLUSIVE OR, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 16/41] s390x/tcg: Implement VECTOR LOAD COMPLEMENT, David Hildenbrand, 2019/04/11
- [Qemu-devel] [PATCH v1 21/41] s390x/tcg: Implement VECTOR NAND, David Hildenbrand, 2019/04/11