[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling
From: |
Bandan Das |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling |
Date: |
Tue, 16 Apr 2019 12:45:04 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Daniel P. Berrangé <address@hidden> writes:
> On Tue, Apr 16, 2019 at 12:10:16PM -0400, Bandan Das wrote:
>> Daniel P. Berrangé <address@hidden> writes:
>> ...
>> >> > The store is read only by default. Are you trying something like:
>> >> > -device usb-mtp,rootdir=/code/mtpshare,readonly=false ?
>> >>
>> >> Ah ha, I didn't realize I had to enable write support explicitly. Will
>> >> retry with that.
>> >
>> > Even after setting readonly=false, I still can't get "mtp-sendfile"
>> > to succeed in a guest.
>> >
>> I posted a patch for a bug introduced by a recent commit that made smaller
>> file sizes return back with a incomplete file transfer.
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg02552.html
>
> Yes, I applied that and didn't see any difference in behaviour
>
Just noticed the error message you posted:
Error sending file.
Error 2: PTP Layer error 02ff: send_file_object_info(): Could not send
object info.
Error 2: Error 02ff: PTP I/O Error
ERROR: Could not close session!
I can't find usb-mtp sending a "I/O error" on an error condition
for the objectinfo phase. It might be libmtp or even the command itself
failing for some reason. For incomplete transfer, I just checked, it's
spitting out the error message correctly as INCOMPLETE_FILE_TRANSFER.
With libmtp version 1.13 on a FC24 guest, here's the output:
$ mtp-sendfile test.txt test.img
libmtp version: 1.1.13
Device 0 (VID=46f4 and PID=0004) is UNKNOWN in libmtp v1.1.13.
Please report this VID/PID and the device model to the libmtp development team
ignoring libusb_claim_interface() = -6PTP_ERROR_IO: failed to open session,
trying again after resetting USB interface
LIBMTP libusb: Attempt to reset device
Sending test.txt to test.img
type: txt, 44
Sending file...
Progress: 322 of 322 (100%)
New file ID: 7
What guest is this ? I can try to reproduce.
> Regards,
> Daniel
- [Qemu-devel] [PATCH 3/3] usb-mtp: fix alignment of access of ObjectInfo filename field, (continued)
- [Qemu-devel] [PATCH 3/3] usb-mtp: fix alignment of access of ObjectInfo filename field, Daniel P . Berrangé, 2019/04/15
- [Qemu-devel] [PATCH 2/3] usb-mtp: fix bounds check for guest provided filename, Daniel P . Berrangé, 2019/04/15
- [Qemu-devel] [PATCH 1/3] usb-mtp: fix string length for filename when writing metadata, Daniel P . Berrangé, 2019/04/15
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Bandan Das, 2019/04/15
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Daniel P . Berrangé, 2019/04/15
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Daniel P . Berrangé, 2019/04/16
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Bandan Das, 2019/04/16
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Daniel P . Berrangé, 2019/04/16
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling,
Bandan Das <=
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Daniel P . Berrangé, 2019/04/16
- Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Bandan Das, 2019/04/16
Re: [Qemu-devel] [PATCH for-4.0? 0/3] usb-mtp: fix ObjectInfo request handling, Eric Blake, 2019/04/15
Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling, Peter Maydell, 2019/04/16