[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 12/15] blockdev: Make -drive format=help print to
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 12/15] blockdev: Make -drive format=help print to stdout |
Date: |
Wed, 17 Apr 2019 21:06:38 +0200 |
Command line help explicitly requested by the user should be printed
to stdout, not stderr. We do elsewhere. Adjust -drive to match: use
qemu_printf() instead of error_printf(). Plain printf() would be
wrong because we need to print to the current monitor for "drive_add
... format=help".
Cc: Kevin Wolf <address@hidden>
Cc: Max Reitz <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
---
blockdev.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 4775a07d93..79fbac8450 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -40,6 +40,7 @@
#include "monitor/monitor.h"
#include "qemu/error-report.h"
#include "qemu/option.h"
+#include "qemu/qemu-print.h"
#include "qemu/config-file.h"
#include "qapi/qapi-commands-block.h"
#include "qapi/qapi-commands-transaction.h"
@@ -301,7 +302,7 @@ DriveInfo *drive_get_next(BlockInterfaceType type)
static void bdrv_format_print(void *opaque, const char *name)
{
- error_printf(" %s", name);
+ qemu_printf(" %s", name);
}
typedef struct {
@@ -530,11 +531,11 @@ static BlockBackend *blockdev_init(const char *file,
QDict *bs_opts,
if ((buf = qemu_opt_get(opts, "format")) != NULL) {
if (is_help_option(buf)) {
- error_printf("Supported formats:");
+ qemu_printf("Supported formats:");
bdrv_iterate_format(bdrv_format_print, NULL, false);
- error_printf("\nSupported formats (read-only):");
+ qemu_printf("\nSupported formats (read-only):");
bdrv_iterate_format(bdrv_format_print, NULL, true);
- error_printf("\n");
+ qemu_printf("\n");
goto early_err;
}
--
2.17.2
- [Qemu-devel] [PATCH v3 00/15] Clean up use of error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 04/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 14/15] char-pty: Print "char device redirected" message to stdout, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 09/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 06/15] hpet: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 05/15] pci: Report fatal errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 12/15] blockdev: Make -drive format=help print to stdout,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 08/15] s390x/kvm: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 15/15] monitor: Simplify how -device/device_add print help, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 10/15] monitor error: Make printf()-like functions return a value, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 03/15] loader-fit: Wean off error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 02/15] block/ssh: Do not report read/write/flush errors to the user, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 11/15] qemu-print: New qemu_printf(), qemu_vprintf() etc., Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 13/15] char: Make -chardev help print to stdout, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 07/15] vfio: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/17