[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/17] monitor: Clean up how monitor_disas()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/17] monitor: Clean up how monitor_disas() funnels output to monitor |
Date: |
Wed, 17 Apr 2019 14:35:34 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/17/19 2:18 PM, Markus Armbruster wrote:
> INIT_DISASSEMBLE_INFO() takes an fprintf()-like callback and a FILE *
> to pass to it. monitor_disas() passes monitor_fprintf() and the
> current monitor cast to FILE *. monitor_fprintf() casts it right
> back, and is otherwise identical to monitor_printf(). The
> type-pinning is ugly.
For consistency with other patches in the series, s/pinning/punning/
>
> Pass qemu_fprintf() and NULL instead.
>
> monitor_fprintf() is now unused; delete it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 02/17] trace: Simplify how st_print_trace_file_status() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 03/17] tcg: Simplify how dump_opcount_info() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 01/17] include: Include fprintf-fn.h only where needed, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 04/17] tcg: Simplify how dump_exec_info() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 05/17] tcg: Simplify how dump_drift_info() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 06/17] qsp: Simplify how qsp_report() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 17/17] include: Move fprintf_function to disas/, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 15/17] monitor: Clean up how monitor_disas() funnels output to monitor, Markus Armbruster, 2019/04/17
- Re: [Qemu-devel] [PATCH v2 15/17] monitor: Clean up how monitor_disas() funnels output to monitor,
Eric Blake <=
- [Qemu-devel] [PATCH v2 13/17] qemu-print: New qemu_fprintf(), qemu_vfprintf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 16/17] disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 12/17] qom/cpu: Simplify how CPUClass::dump_statistics() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 08/17] memory: Clean up how mtree_info() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 07/17] block/qapi: Clean up how we print to monitor or stdout, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 11/17] target/i386: Simplify how x86_cpu_dump_local_apic_state() prints, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v2 09/17] target: Simplify how the TARGET_cpu_list() print, Markus Armbruster, 2019/04/17