[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/6] tests/vhost-user-bridge: Fix misuse of isdigit(
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 2/6] tests/vhost-user-bridge: Fix misuse of isdigit() |
Date: |
Thu, 18 Apr 2019 16:53:51 +0200 |
vubr_set_host() passes char values to isdigit(). Undefined behavior
when the value is negative.
Fix by using qemu_isdigit() instead.
Signed-off-by: Markus Armbruster <address@hidden>
---
tests/vhost-user-bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 0033b61f2e..d70b107ebc 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -645,7 +645,7 @@ vubr_host_notifier_setup(VubrDev *dev)
static void
vubr_set_host(struct sockaddr_in *saddr, const char *host)
{
- if (isdigit(host[0])) {
+ if (qemu_isdigit(host[0])) {
if (!inet_aton(host, &saddr->sin_addr)) {
fprintf(stderr, "inet_aton() failed.\n");
exit(1);
--
2.17.2
- [Qemu-devel] [PATCH 0/6] Fix misuse of ctype.h functions, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 5/6] pc-bios/s390-ccw: Clean up harmless misuse of isdigit(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 4/6] gdbstub: Fix misuse of isxdigit(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 6/6] cutils: Simplify how parse_uint() checks for whitespace, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 2/6] tests/vhost-user-bridge: Fix misuse of isdigit(),
Markus Armbruster <=
- [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace(), Markus Armbruster, 2019/04/18