[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback supp
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support |
Date: |
Thu, 18 Apr 2019 09:18:34 -0700 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, Apr 18, 2019 at 09:05:05AM -0700, Dan Williams wrote:
> > > I'd either add a comment about avoiding retpoline overhead here or just
> > > make ->flush == NULL mean generic_nvdimm_flush(). Just so that people
> > > don't
> > > get confused by the code.
> >
> > Isn't this premature optimization? I really don't like adding things
> > like this without some numbers to show it's worth it.
>
> I don't think it's premature given this optimization technique is
> already being deployed elsewhere, see:
>
> https://lwn.net/Articles/774347/
For one this one was backed by numbers, and second after feedback
from Linux we switched to the NULL pointer check instead.
- [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, (continued)
- [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Pankaj Gupta, 2019/04/10
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Jan Kara, 2019/04/12
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Jeff Moyer, 2019/04/12
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Pankaj Gupta, 2019/04/18
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Dan Williams, 2019/04/18
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Jeff Moyer, 2019/04/18
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support,
Christoph Hellwig <=
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Dan Williams, 2019/04/18
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Jeff Moyer, 2019/04/22
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Dan Williams, 2019/04/22
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Jeff Moyer, 2019/04/22
- Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support, Pankaj Gupta, 2019/04/23
[Qemu-devel] [PATCH v5 4/6] dax: check synchronous mapping is supported, Pankaj Gupta, 2019/04/10
[Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver, Pankaj Gupta, 2019/04/10