[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] numa: move numa global variable numa_inf
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] numa: move numa global variable numa_info into MachineState |
|
Date: |
Thu, 18 Apr 2019 17:28:20 -0300 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Apr 18, 2019 at 02:46:02PM +0800, Tao Xu wrote:
> The aim of this patch is to move existing numa global numa_info
> into NumaState.
>
> Suggested-by: Igor Mammedov <address@hidden>
> Suggested-by: Eduardo Habkost <address@hidden>
> Signed-off-by: Tao Xu <address@hidden>
`ms->numa_state->numa_info[i]` is not a very descriptive
expression. Also, we don't need the "numa" prefix anymore, if
the identifier is not in global scope.
I suggest renaming it to NumaState::nodes. So this:
> ms->numa_state->numa_info[i].distance[j]
would become:
ms->numa_state->nodes[i].distance[j]
This wouldn't block me from merging this patch, but it's a
suggestion in case you send v3 to address the comments on patch
1/3.
--
Eduardo