[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-4.1 18/36] char-pty: Print "char device redirecte
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL for-4.1 18/36] char-pty: Print "char device redirected" message to stdout |
Date: |
Thu, 18 Apr 2019 22:51:17 +0200 |
char_pty_open() prints a "char device redirected to PTY_NAME (label
LABEL)" message to the current monitor or else to stderr. This is not
an error, so it shouldn't go to stderr. Print it to stdout instead.
Why is it even printed? No other ChardevClass::open() prints anything
on success. It's because you need to know PTY_NAME to actually use
this char device, e.g. like e.g. "socat STDIO,cfmakeraw FILE:PTY_NAME"
to use the monitor's readline interface. You can get PTY_NAME with
"info chardev" (a.k.a. query-chardev for QMP), but only if you already
have a monitor.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
chardev/char-pty.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/chardev/char-pty.c b/chardev/char-pty.c
index b034332edd..04759b0ef9 100644
--- a/chardev/char-pty.c
+++ b/chardev/char-pty.c
@@ -28,6 +28,7 @@
#include "io/channel-file.h"
#include "qemu/sockets.h"
#include "qemu/error-report.h"
+#include "qemu/qemu-print.h"
#include "chardev/char-io.h"
@@ -211,8 +212,8 @@ static void char_pty_open(Chardev *chr,
qemu_set_nonblock(master_fd);
chr->filename = g_strdup_printf("pty:%s", pty_name);
- error_printf("char device redirected to %s (label %s)\n",
- pty_name, chr->label);
+ qemu_printf("char device redirected to %s (label %s)\n",
+ pty_name, chr->label);
s = PTY_CHARDEV(chr);
s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));
--
2.17.2
- [Qemu-devel] [PULL for-4.1 22/36] tcg: Simplify how dump_opcount_info() prints, (continued)
- [Qemu-devel] [PULL for-4.1 22/36] tcg: Simplify how dump_opcount_info() prints, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 32/36] qemu-print: New qemu_fprintf(), qemu_vfprintf(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 11/36] vfio: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 20/36] include: Include fprintf-fn.h only where needed, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 19/36] monitor: Simplify how -device/device_add print help, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 30/36] target/i386: Simplify how x86_cpu_dump_local_apic_state() prints, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 34/36] monitor: Clean up how monitor_disas() funnels output to monitor, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 17/36] char: Make -chardev help print to stdout, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 28/36] target: Simplify how the TARGET_cpu_list() print, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 35/36] disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 18/36] char-pty: Print "char device redirected" message to stdout,
Markus Armbruster <=
- [Qemu-devel] [PULL for-4.1 09/36] pci: Report fatal errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 21/36] trace: Simplify how st_print_trace_file_status() prints, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 10/36] hpet: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 15/36] qemu-print: New qemu_printf(), qemu_vprintf() etc., Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 05/36] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 26/36] block/qapi: Clean up how we print to monitor or stdout, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 23/36] tcg: Simplify how dump_exec_info() prints, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 25/36] qsp: Simplify how qsp_report() prints, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 24/36] tcg: Simplify how dump_drift_info() prints, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PULL for-4.1 16/36] blockdev: Make -drive format=help print to stdout, Markus Armbruster, 2019/04/18