Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix a crash in COLO Primary.

[Zhang, Chen]

> -----Original Message-----
> From: Lukas Straub [mailto:address@hidden
> Sent: Friday, April 19, 2019 9:56 PM
> To: address@hidden
> Cc: Zhang, Chen <address@hidden>
> Subject: [PATCH] net/colo-compare.c: Fix a crash in COLO Primary.
> 
> From: Lukas Straub <address@hidden> Fixes the following bug:
> https://bugs.launchpad.net/qemu/+bug/1824622

It looks good for me, but I think you need add more comments in commit message,
For example what situation will trigger this bug and why it will occur.
After that, I think you can close the bug in Launchpad.

Thanks
Zhang Chen

> 
> Signed-off-by: Lukas Straub <address@hidden>
> ---
>  net/colo-compare.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/colo-compare.c b/net/colo-compare.c index
> bf10526f05..fcb491121b 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -813,9 +813,8 @@ static void colo_compare_handle_event(void *opaque)
>          break;
>      }
> 
> -    assert(event_unhandled_count > 0);
> -
>      qemu_mutex_lock(&event_mtx);
> +    assert(event_unhandled_count > 0);
>      event_unhandled_count--;
>      qemu_cond_broadcast(&event_complete_cond);
>      qemu_mutex_unlock(&event_mtx);
> --
> 2.20.1