[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fixup! qtest: Move accel code to accel/qtest.c
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] fixup! qtest: Move accel code to accel/qtest.c |
Date: |
Tue, 23 Apr 2019 13:29:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 23/04/2019 13.08, Eduardo Habkost wrote:
> On Tue, Apr 23, 2019 at 07:07:06AM +0200, Thomas Huth wrote:
>> On 22/04/2019 23.04, Eduardo Habkost wrote:
>>> QTest has two parts: the server (-qtest) and the accelerator
>>> (-machine accel=qtest). The accelerator depends on CONFIG_POSIX
>>> due to its usage of sigwait(), but the server doesn't.
>>>
>>> Move the accel code to accel/qtest.c. Later we will disable
>>> compilation of accel/qtest.c on non-POSIX systems.
>>>
>>> Signed-off-by: Eduardo Habkost <address@hidden>
>>> ---
>>> accel/qtest.c | 55 +++++++++++++++++++++++++++++++++++++++++++++
>>
>> New file ==> You should update MAINTAINERS here as well.
>
> Oops, sorry! Fixup below.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 56139ac8ab..cf3156d952 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2024,6 +2024,7 @@ M: Laurent Vivier <address@hidden>
> R: Paolo Bonzini <address@hidden>
> S: Maintained
> F: qtest.c
> +F: accel/qtest.c
> F: tests/libqtest.*
> F: tests/libqos/
> F: tests/*-test.c
All right, queued the patches on my qtest-next branch:
https://gitlab.com/huth/qemu/tree/qtest-next
Thanks,
Thomas
- Re: [Qemu-devel] [PATCH 3/3] accel: Remove unused AccelClass::available field, (continued)