[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] target/mips: Clean up lmi_helper.c
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] target/mips: Clean up lmi_helper.c |
Date: |
Tue, 23 Apr 2019 15:51:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/23/19 1:29 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
>
> Remove several minor checkpatch warnings and errors.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> target/mips/lmi_helper.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/target/mips/lmi_helper.c b/target/mips/lmi_helper.c
> index fb1245b..6c645cf 100644
> --- a/target/mips/lmi_helper.c
> +++ b/target/mips/lmi_helper.c
> @@ -21,9 +21,11 @@
> #include "cpu.h"
> #include "exec/helper-proto.h"
>
> -/* If the byte ordering doesn't matter, i.e. all columns are treated
> - identically, then this union can be used directly. If byte ordering
> - does matter, we generally ignore dumping to memory. */
> +/*
> + * If the byte ordering doesn't matter, i.e. all columns are treated
> + * identically, then this union can be used directly. If byte ordering
> + * does matter, we generally ignore dumping to memory.
> + */
> typedef union {
> uint8_t ub[8];
> int8_t sb[8];
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-devel] [PATCH 0/8] target/mips: Clean up misc code segments, Aleksandar Markovic, 2019/04/23
- [Qemu-devel] [PATCH 4/8] target/mips: Add * to comments and realign them to fix checkpatch warnings, Aleksandar Markovic, 2019/04/23
- [Qemu-devel] [PATCH 3/8] target/mips: Remove a space before open parenthesis to fix checkpatch errors, Aleksandar Markovic, 2019/04/23
- [Qemu-devel] [PATCH 2/8] target/mips: Realign comments to fix checkpatch warnings, Aleksandar Markovic, 2019/04/23
- [Qemu-devel] [PATCH 7/8] target/mips: Fix some space checkpatch errors in translate.c, Aleksandar Markovic, 2019/04/23
- [Qemu-devel] [PATCH 6/8] target/mips: Clean up lmi_helper.c, Aleksandar Markovic, 2019/04/23
- Re: [Qemu-devel] [PATCH 6/8] target/mips: Clean up lmi_helper.c,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 1/8] target/mips: Add or remove space to fix checkpatch errors, Aleksandar Markovic, 2019/04/23
- [Qemu-devel] [PATCH 8/8] target/mips: Fix if-else arms checkpatch errors in translate.c, Aleksandar Markovic, 2019/04/23
- [Qemu-devel] [PATCH 5/8] target/mips: Clean up dsp_helper.c, Aleksandar Markovic, 2019/04/23