Re: [Qemu-devel] [PATCH 1/4] tests: refactor fw_cfg_test

[Thomas Huth]

On 20/04/2019 12.00, Li Qiang wrote:
> Currently, fw_cfg_test uses one QTestState for every test case.
> This will add all command lines for every test case and
> this is unnecessary. This patch split the test cases and for
> every test case it uses his own QTestState. This patch does following
> things:
> 
> 1. Get rid of the global 'fw_cfg', this need add a uninit function
> 
> 2. Convert every test case in a separate QTestState
> 
> After this patch, we can add fw_cfg test case freely and will not
> have efect other test cases.
> 
> Signed-off-by: Li Qiang <address@hidden>
> ---
>  tests/fw_cfg-test.c   | 86 ++++++++++++++++++++++++++++++++++++++-----
>  tests/libqos/fw_cfg.c | 10 +++++
>  tests/libqos/fw_cfg.h |  7 ++++
>  3 files changed, 94 insertions(+), 9 deletions(-)

Sounds like a good idea.

Acked-by: Thomas Huth <address@hidden>