qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info throug


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP
Date: Wed, 24 Apr 2019 09:56:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 23/04/2019 23.22, Eduardo Habkost wrote:
> This series adds machine type deprecation information to the
> output of the `query-machines` QMP command.  With this, libvirt
> and management software will be able to show this information to
> users and/or suggest changes to VM configuration to avoid
> deprecated machine types.
> 
> Eduardo Habkost (3):
>   qapi: SupportStatusInfo struct
>   machine: Use SupportStatusInfo for deprecation info
>   qmp: Add deprecation information to query-machines
> 
>  qapi/common.json                   | 24 ++++++++++++++++++++++++
>  qapi/misc.json                     |  5 ++++-
>  include/hw/boards.h                |  7 ++++---
>  hw/i386/pc_piix.c                  |  4 +++-
>  hw/ppc/prep.c                      |  4 +++-
>  vl.c                               | 19 +++++++++++++++----
>  tests/acceptance/query_machines.py | 27 +++++++++++++++++++++++++++
>  7 files changed, 80 insertions(+), 10 deletions(-)
>  create mode 100644 tests/acceptance/query_machines.py

Good idea, but some questions come to my mind:

- What about devices? IIRC Gerd wrote a patch series last year that does
  something similar for devices... It would be good to synchronize the
  work, so that we do not have two completely interfaces between devices
  and machines here in the end...

- Is deprecation as a status enough, or do we want to carry more
  information here? E.g. is the machine maintained or orphan? Is it
  stable or rather experimental? And didn't Gerd have also some
  patches for this last year? ... yes, I think it was this series here:
  http://lists.gnu.org/archive/html/qemu-ppc/2018-11/msg00039.html
  ... actually, I like that idea with QemuSupportState... maybe you
  could base your work on that series instead?

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]