[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] hmp: delvm: use hmp_handle_error
From: |
Cole Robinson |
Subject: |
[Qemu-devel] [PATCH v2] hmp: delvm: use hmp_handle_error |
Date: |
Wed, 24 Apr 2019 17:49:08 -0400 |
This gives us the consistent 'Error:' prefix added in 66363e9a43f,
which helps users like libvirt who still need to scrape hmp error
messages to detect failure.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
---
v2:
Drop now redundant "Error while" string prefix
hmp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hmp.c b/hmp.c
index 4bb3af748e..56a3ed7375 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1480,10 +1480,11 @@ void hmp_delvm(Monitor *mon, const QDict *qdict)
const char *name = qdict_get_str(qdict, "name");
if (bdrv_all_delete_snapshot(name, &bs, &err) < 0) {
- error_reportf_err(err,
- "Error while deleting snapshot on device '%s': ",
- bdrv_get_device_name(bs));
+ error_prepend(&err,
+ "deleting snapshot on device '%s': ",
+ bdrv_get_device_name(bs));
}
+ hmp_handle_error(mon, &err);
}
void hmp_info_snapshots(Monitor *mon, const QDict *qdict)
--
2.21.0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH v2] hmp: delvm: use hmp_handle_error,
Cole Robinson <=