Re: [Qemu-devel] [PATCH v3 02/13] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

[Wei Yang]

On Thu, Apr 25, 2019 at 07:34:38AM +0200, Igor Mammedov wrote:
>so name would reflect what the function does
>
>Signed-off-by: Igor Mammedov <address@hidden>
>Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Wei Yang <address@hidden>

>---
> tests/acpi-utils.h       | 2 +-
> tests/acpi-utils.c       | 2 +-
> tests/bios-tables-test.c | 2 +-
> tests/vmgenid-test.c     | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h
>index 8c68201..75f78f2 100644
>--- a/tests/acpi-utils.h
>+++ b/tests/acpi-utils.h
>@@ -46,7 +46,7 @@ typedef struct {
> 
> uint8_t acpi_calc_checksum(const uint8_t *data, int len);
> uint32_t acpi_find_rsdp_address(QTestState *qts);
>-void acpi_parse_rsdp_table(QTestState *qts, uint64_t addr, uint8_t 
>*rsdp_table);
>+void acpi_fetch_rsdp_table(QTestState *qts, uint64_t addr, uint8_t 
>*rsdp_table);
> void acpi_fetch_table(QTestState *qts, uint8_t **aml, uint32_t *aml_len,
>                       const uint8_t *addr_ptr, const char *sig,
>                       bool verify_checksum);
>diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c
>index 9a6d1d3..2dd4fe0 100644
>--- a/tests/acpi-utils.c
>+++ b/tests/acpi-utils.c
>@@ -51,7 +51,7 @@ uint32_t acpi_find_rsdp_address(QTestState *qts)
>     return off;
> }
> 
>-void acpi_parse_rsdp_table(QTestState *qts, uint64_t addr, uint8_t 
>*rsdp_table)
>+void acpi_fetch_rsdp_table(QTestState *qts, uint64_t addr, uint8_t 
>*rsdp_table)
> {
>     uint8_t revision;
> 
>diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
>index 24bd102..2ee044c 100644
>--- a/tests/bios-tables-test.c
>+++ b/tests/bios-tables-test.c
>@@ -89,7 +89,7 @@ static void test_acpi_rsdp_table(test_data *data)
>     uint8_t *rsdp_table = data->rsdp_table, revision;
>     uint32_t addr = data->rsdp_addr;
> 
>-    acpi_parse_rsdp_table(data->qts, addr, rsdp_table);
>+    acpi_fetch_rsdp_table(data->qts, addr, rsdp_table);
>     revision = rsdp_table[15 /* Revision offset */];
> 
>     switch (revision) {
>diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c
>index ae38ee5..f400184 100644
>--- a/tests/vmgenid-test.c
>+++ b/tests/vmgenid-test.c
>@@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(QTestState *qts)
>     g_assert_cmphex(rsdp_offset, <, RSDP_ADDR_INVALID);
> 
> 
>-    acpi_parse_rsdp_table(qts, rsdp_offset, rsdp_table);
>+    acpi_fetch_rsdp_table(qts, rsdp_offset, rsdp_table);
>     acpi_fetch_table(qts, &rsdt, &rsdt_len, &rsdp_table[16 /* RsdtAddress */],
>                      "RSDT", true);
> 
>-- 
>2.7.4

-- 
Wei Yang
Help you, Help me