[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] linux-user: Fix support for the SIOCATMA
From: |
Max Filippov |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] linux-user: Fix support for the SIOCATMARK and SIOCGPGRP ioctls for eXtensa |
Date: |
Thu, 25 Apr 2019 22:10:55 -0700 |
On Wed, Apr 24, 2019 at 5:57 AM Aleksandar Markovic
<address@hidden> wrote:
> From: Aleksandar Markovic <address@hidden>
>
> Fix support for the SIOCATMARK and SIOCGPGRP ioctls for eXtensa by
xtensa is the official name of this architecture, please fix the spelling
here...
> correcting corresponding macro definition.
>
> Values for TARGET_SIOCATMARK and TARGET_SIOCGPGRP are determined by
> Linux kernel. Following relevant lines are from kernel source tree:
>
> arch/ia64/include/uapi/asm/sockios.h:#define SIOCATMARK 0x8905
> arch/mips/include/uapi/asm/sockios.h:#define SIOCATMARK _IOR('s', 7, int)
> arch/parisc/include/uapi/asm/sockios.h:#define SIOCATMARK 0x8905
> arch/sh/include/uapi/asm/sockios.h:#define SIOCATMARK _IOR('s', 7, int)
> arch/xtensa/include/uapi/asm/sockios.h:#define SIOCATMARK _IOR('s', 7, int)
> arch/alpha/include/uapi/asm/sockios.h:#define SIOCATMARK _IOR('s', 7, int)
> arch/sparc/include/uapi/asm/sockios.h:#define SIOCATMARK 0x8905
> include/uapi/asm-generic/sockios.h:#define SIOCATMARK 0x8905
>
> arch/ia64/include/uapi/asm/sockios.h:#define SIOCGPGRP 0x8904
> arch/mips/include/uapi/asm/sockios.h:#define SIOCGPGRP _IOR('s', 9, pid_t)
> arch/parisc/include/uapi/asm/sockios.h:#define SIOCGPGRP 0x8904
> arch/sh/include/uapi/asm/sockios.h:#define SIOCGPGRP _IOR('s', 9, pid_t)
> arch/xtensa/include/uapi/asm/sockios.h:#define SIOCGPGRP _IOR('s', 9, pid_t)
> arch/alpha/include/uapi/asm/sockios.h:#define SIOCGPGRP _IOR('s', 9, pid_t)
> arch/sparc/include/uapi/asm/sockios.h:#define SIOCGPGRP 0x8904
> include/uapi/asm-generic/sockios.h:#define SIOCGPGRP 0x8904
>
> It is visible that eXtensa should have the same definitions as
...here, and in the subject line.
> alpha, mips and sh4 already do. This patch brings that to the
> accurate state.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> linux-user/syscall_defs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Max Filippov <address@hidden>
--
Thanks.
-- Max
- [Qemu-devel] [PATCH v2 0/5] linux-user: A set of misc patches for 4.1, Aleksandar Markovic, 2019/04/24
- [Qemu-devel] [PATCH v2 5/5] linux-user: Sanitize interp_info and, for mips only, init field fp_abi, Aleksandar Markovic, 2019/04/24
- [Qemu-devel] [PATCH v2 4/5] linux-user: setsockopt(): Add support for the option IPV6_ADD_MEMBERSHIP, Aleksandar Markovic, 2019/04/24
- [Qemu-devel] [PATCH v2 3/5] linux-user: Add support the SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls, Aleksandar Markovic, 2019/04/24
- [Qemu-devel] [PATCH v2 1/5] linux-user: Fix support for the SIOCATMARK and SIOCGPGRP ioctls for eXtensa, Aleksandar Markovic, 2019/04/24
- [Qemu-devel] [PATCH v2 2/5] linux-user: Add support for the SIOCSPGRP ioctl, Aleksandar Markovic, 2019/04/24