Re: [Qemu-devel] [PATCH v2 02/10] s390x/cpumodel: ignore csske for expansion

[David Hildenbrand]

On 26.04.19 13:09, Christian Borntraeger wrote:
> csske will be removed in a future machine. Ignore it for expanding the
> cpu model. Otherwise qemu falls back to z9.
> 
> Signed-off-by: Christian Borntraeger <address@hidden>
> Cc: address@hidden
> ---
>  target/s390x/cpu_models.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index e5afa15512..b4bb5de635 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -1322,6 +1322,8 @@ static void init_ignored_base_feat(void)
>           S390_FEAT_KM_TDEA_192,
>           S390_FEAT_KIMD_SHA_1,
>           S390_FEAT_KLMD_SHA_1,
> +         /* CSSKE is deprecated on newer generations */
> +         S390_FEAT_CONDITIONAL_SSKE,
>      };
>      int i;
>  
> 

Reviewed-by: David Hildenbrand <address@hidden>

-- 

Thanks,

David / dhildenb