Re: [Qemu-devel] [PULL 00/15] tcg patch queue

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/15] tcg patch queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3b5fbad27a cputlb: Fix io_readx() to respect the access_type
b5538c441b tcg/arm: Restrict constant pool displacement to 12 bits
d42c651923 tcg/ppc: Allow the constant pool to overflow at 32k
0c1b8687b1 tcg: Restart TB generation after out-of-line ldst overflow
e21b05fbc8 tcg: Restart TB generation after constant pool overflow
7c567fa038 tcg: Restart TB generation after relocation overflow
8ec60692fc tcg: Restart after TB code generation overflow
e204222382 tcg: Hoist max_insns computation to tb_gen_code
498c455395 tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
e132577400 tcg/arm: Support INDEX_op_extract2_i32
c312fddc72 tcg/i386: Support INDEX_op_extract2_{i32, i64}
29311ac09e tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
1dcf4ab4f1 tcg: Use deposit and extract2 in tcg_gen_shifti_i64
1ac2ae251b tcg: Add INDEX_op_extract2_{i32,i64}
12e84a540d tcg: Implement tcg_gen_extract2_{i32, i64}

=== OUTPUT BEGIN ===
1/15 Checking commit 12e84a540d21 (tcg: Implement tcg_gen_extract2_{i32, i64})
2/15 Checking commit 1ac2ae251b21 (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#111: FILE: tcg/optimize.c:1205:
+        CASE_OP_32_64(extract2):
                                ^

total: 1 errors, 0 warnings, 207 lines checked

Patch 2/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/15 Checking commit 1dcf4ab4f1d3 (tcg: Use deposit and extract2 in 
tcg_gen_shifti_i64)
4/15 Checking commit 29311ac09eb0 (tcg: Use extract2 in tcg_gen_deposit_{i32, 
i64})
5/15 Checking commit c312fddc729f (tcg/i386: Support INDEX_op_extract2_{i32, 
i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+    OP_32_64(extract2):
                       ^

total: 1 errors, 0 warnings, 51 lines checked

Patch 5/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/15 Checking commit e13257740058 (tcg/arm: Support INDEX_op_extract2_i32)
7/15 Checking commit 498c455395dc (tcg/aarch64: Support INDEX_op_extract2_{i32, 
i64})
8/15 Checking commit e204222382ef (tcg: Hoist max_insns computation to 
tb_gen_code)
9/15 Checking commit 8ec60692fce4 (tcg: Restart after TB code generation 
overflow)
10/15 Checking commit 7c567fa0386d (tcg: Restart TB generation after relocation 
overflow)
11/15 Checking commit e21b05fbc853 (tcg: Restart TB generation after constant 
pool overflow)
12/15 Checking commit 0c1b8687b192 (tcg: Restart TB generation after 
out-of-line ldst overflow)
13/15 Checking commit d42c651923aa (tcg/ppc: Allow the constant pool to 
overflow at 32k)
14/15 Checking commit b5538c441b12 (tcg/arm: Restrict constant pool 
displacement to 12 bits)
15/15 Checking commit 3b5fbad27a48 (cputlb: Fix io_readx() to respect the 
access_type)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden