Re: [Qemu-devel] [PATCH] hw/tpm: Only build tpm_ppi.o if any of TPM_TIS/TPM_CRB is built

[Stefan Berger]

On 4/27/19 9:18 AM, Philippe Mathieu-Daudé wrote:
> The TPM Physical Presence Interface routines are only used
> by the CRB/TIS interfaces. Do not compile this file if any
> of them is built.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>


Reviewed-by: Stefan Berger <address@hidden>


> ---
> Marc-André:
>    You might want to add yourself as reviewer/maintainer of TPM ;)
> ---
>   hw/tpm/Makefile.objs | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/tpm/Makefile.objs b/hw/tpm/Makefile.objs
> index 700c8786228..de0b85d02ae 100644
> --- a/hw/tpm/Makefile.objs
> +++ b/hw/tpm/Makefile.objs
> @@ -1,5 +1,5 @@
> -common-obj-y += tpm_util.o
> -obj-y += tpm_ppi.o
> +common-obj-$(CONFIG_TPM) += tpm_util.o
> +obj-$(call lor,$(CONFIG_TPM_TIS),$(CONFIG_TPM_CRB)) += tpm_ppi.o
>   common-obj-$(CONFIG_TPM_TIS) += tpm_tis.o
>   common-obj-$(CONFIG_TPM_CRB) += tpm_crb.o
>   common-obj-$(CONFIG_TPM_PASSTHROUGH) += tpm_passthrough.o