Re: [Qemu-devel] [PATCH for-4.1 v2 28/36] target/xtensa: Use env_cpu, env_archcpu

[Peter Maydell]

On Mon, 29 Apr 2019 at 16:20, Richard Henderson
<address@hidden> wrote:
>
> On 4/29/19 7:36 AM, Peter Maydell wrote:
> > On Thu, 28 Mar 2019 at 23:38, Richard Henderson
> > <address@hidden> wrote:
> >>
> >> Signed-off-by: Richard Henderson <address@hidden>
> >> ---
> >> @@ -712,10 +707,15 @@ static inline int cpu_mmu_index(CPUXtensaState *env, 
> >> bool ifetch)
> >>  #define XTENSA_CSBASE_LBEG_OFF_MASK 0x00ff0000
> >>  #define XTENSA_CSBASE_LBEG_OFF_SHIFT 16
> >>
> >> +typedef CPUXtensaState CPUArchState;
> >> +typedef XtensaCPU ArchCPU;
> >> +
> >> +#include "exec/cpu-all.h"
> >
> > Shouldn't this bit be in an earlier patch ?
>
> The diff is just funny here.
>
> As with cris, it's really moving the following function below
> exec/cpu-all.h, so that env_archcpu is defined.

Oh, I see. With a note in the commit message about the
function definition moving

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM