[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.1 v2 36/36] tcg/arm: Use LDRD to load tlb
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH for-4.1 v2 36/36] tcg/arm: Use LDRD to load tlb mask+table |
|
Date: |
Mon, 29 Apr 2019 08:42:55 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/29/19 8:00 AM, Peter Maydell wrote:
> On Thu, 28 Mar 2019 at 23:23, Richard Henderson
> <address@hidden> wrote:
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> tcg/arm/tcg-target.inc.c | 109 +++++++++++++++++++--------------------
>> 1 file changed, 52 insertions(+), 57 deletions(-)
>
> I think this would be easier to understand if the commit message
> included what the old and new generated code fragments looked like.
Fair enough. This change is complicated by having
to rearrange register usage, so that we ldrd into r0+r1
instead of ldr into r1+r2, etc. Just this once it would
have been easier in thumb2. ;-)
> The same remark about a compile-time check that mask and
> table are where we expect from patch 35 applies here too.
Ok.
r~