[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/4] linux-user: Parse NT_GNU_PROPERTY_TYPE_0
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 3/4] linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes |
|
Date: |
Mon, 29 Apr 2019 13:18:23 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/29/19 9:17 AM, Peter Maydell wrote:
>> + struct elf_phdr *eppnt = phdr + i;
>> +
>> + switch (eppnt->p_type) {
>> + case PT_LOAD:
>> + {
>
> I think you have an extra layer of indent here that we usually
> don't do for switch statement cases.
No, that indent is exactly right for a compound statement
not associated with an if/while/whatnot.
> #define GNU0_MAGIC const_le32('G' | 'N' << 8 | 'U' << 16)
>
> and then you can avoid the #ifdef HOST_WORDS_BIGENDIAN?
Sure.
r~