Re: [Qemu-devel] [PATCH] s390-bios: Skip bootmap signature entries

[Cornelia Huck]

On Tue, 30 Apr 2019 11:24:27 +0200
Peter Oberparleiter <address@hidden> wrote:

> On 29.04.2019 15:45, Christian Borntraeger wrote:
> > 
> > 
> > On 29.04.19 15:40, Cornelia Huck wrote:  
> >> On Mon, 29 Apr 2019 09:09:41 -0400
> >> "Jason J. Herne" <address@hidden> wrote:
> >>  
> >>> Newer versions of zipl have the ability to write signature entries to the 
> >>> boot
> >>> script for secure boot. We don't yet support secure boot, but we need to 
> >>> skip
> >>> over signature entries while reading the boot script in order to maintain 
> >>> our
> >>> ability to boot guest operating systems that have a secure bootloader.
> >>>
> >>> Signed-off-by: Jason J. Herne <address@hidden>
> >>> Reviewed-by: Farhan Ali <address@hidden>
> >>> ---
> >>>  pc-bios/s390-ccw/bootmap.c | 19 +++++++++++++++++--
> >>>  pc-bios/s390-ccw/bootmap.h | 10 ++++++----
> >>>  2 files changed, 23 insertions(+), 6 deletions(-)  
> >>
> >> Skipping something that we don't have support for yet, but that doesn't
> >> hinder normal operation sounds reasonable; but can you point me to the
> >> relevant commit implementing this in zipl or some documentation? I
> >> haven't been able to find something like that in the s390-tools git
> >> tree.  
> > 
> > the s390-tools update is currently in preparation, adding Stefan and Peter. 
> >  
> 
> Here's the link to the s390-tools commit that introduces the new
> signature component to zipl:
> 
> https://github.com/ibm-s390-tools/s390-tools/commit/7c7e10ed8fb048efc4e0cd91b0f6fa704fba128e
> 
> 

Thanks!