[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/26] target/cris: Convert to CPUClass::tlb_fil
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 05/26] target/cris: Convert to CPUClass::tlb_fill |
Date: |
Tue, 30 Apr 2019 12:57:56 +0100 |
On Wed, 3 Apr 2019 at 04:46, Richard Henderson
<address@hidden> wrote:
>
> Cc: Edgar E. Iglesias <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/cris/cpu.h | 5 +--
> target/cris/cpu.c | 5 ++-
> target/cris/helper.c | 67 +++++++++++++++++++++++------------------
> target/cris/op_helper.c | 28 -----------------
> 4 files changed, 42 insertions(+), 63 deletions(-)
> -int cris_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw,
> - int mmu_idx)
> +bool cris_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
> + MMUAccessType access_type, int mmu_idx,
> + bool probe, uintptr_t retaddr)
> {
> CRISCPU *cpu = CRIS_CPU(cs);
>
> cs->exception_index = 0xaa;
> cpu->env.pregs[PR_EDA] = address;
> - cpu_dump_state(cs, stderr, fprintf, 0);
> - return 1;
> + cpu_loop_exit_restore(cs, retaddr);
You might mention in the commit message that we removed the
cpu_dump_state().
> + env->pregs[PR_EDA] = address;
> + cs->exception_index = EXCP_BUSFAULT;
> + env->fault_vector = res.bf_vec;
> + if (retaddr) {
> + if (cpu_restore_state(cs, retaddr, true)) {
> + /* Evaluate flags after retranslation. */
> + helper_top_evaluate_flags(env);
Side note because the old code does the same thing, but it seems
weird that we have to manually recalculate the flags here -- I
would expect cpu_restore_state() to actually restore the state
(presumably by having restore_state_to_opc() do the fixing up
of the flags?).
> + }
> + }
> + cpu_loop_exit(cs);
> +}
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 01/26] tcg: Assert h2g_valid for 32-bit guest on 64-bit host, (continued)
- [Qemu-devel] [PATCH 02/26] tcg: Add CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 03/26] target/alpha: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 04/26] target/arm: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 05/26] target/cris: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- Re: [Qemu-devel] [PATCH 05/26] target/cris: Convert to CPUClass::tlb_fill,
Peter Maydell <=
- [Qemu-devel] [PATCH 06/26] target/hppa: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 08/26] target/lm32: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 07/26] target/i386: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 09/26] target/m68k: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 10/26] target/microblaze: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02