[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length
From: |
Bruce Rogers |
Subject: |
[Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length |
Date: |
Tue, 30 Apr 2019 07:19:46 -0600 |
While investigating link-time-optimization, the compiler flagged this
case of not handling the error return from scsi_cdb_length(). Handle
this error case with a trace report.
Signed-off-by: Bruce Rogers <address@hidden>
---
hw/scsi/scsi-disk.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index e7e865ab3b..8fbf7512e5 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2520,6 +2520,10 @@ static void scsi_disk_new_request_dump(uint32_t lun,
uint32_t tag, uint8_t *buf)
int len = scsi_cdb_length(buf);
char *line_buffer, *p;
+ if (len < 0) {
+ trace_scsi_disk_new_request(lun, tag, "bad cdb length");
+ return;
+ }
line_buffer = g_malloc(len * 5 + 1);
for (i = 0, p = line_buffer; i < len; i++) {
--
2.21.0
- [Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length,
Bruce Rogers <=