[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/5] armv7m: Allow entry information to be re
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/5] armv7m: Allow entry information to be returned |
Date: |
Tue, 30 Apr 2019 17:04:03 +0100 |
On Mon, 29 Apr 2019 at 06:34, Alistair Francis <address@hidden> wrote:
>
> Allow the kernel's entry point information to be returned when loading a
> kernel.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
> hw/arm/armv7m.c | 6 +++---
> hw/arm/microbit.c | 2 +-
> hw/arm/mps2-tz.c | 3 ++-
> hw/arm/mps2.c | 2 +-
> hw/arm/msf2-som.c | 2 +-
> hw/arm/musca.c | 3 ++-
> hw/arm/netduino2.c | 2 +-
> hw/arm/stellaris.c | 3 ++-
> include/hw/arm/arm.h | 4 +++-
> 9 files changed, 16 insertions(+), 11 deletions(-)
> -void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int
> mem_size)
> +void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int
> mem_size,
> + uint64_t *entry)
If we need to return the entry point, why not just return it
as the return value of the function rather than having the
caller pass in a pointer which we fill in ?
thanks
-- PMM