Re: [Qemu-devel] [PATCH 09/14] target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c

[Richard Henderson]

On 4/28/19 7:38 AM, Mark Cave-Ayland wrote:
> -void helper_xsrqpi(CPUPPCState *env, uint32_t opcode)
> +void helper_xsrqpi(CPUPPCState *env, uint32_t opcode,
> +                   ppc_vsr_t *xt, ppc_vsr_t *xb)
>  {
> -    ppc_vsr_t *xt = &env->vsr[rD(opcode) + 32];
> -    ppc_vsr_t *xb = &env->vsr[rB(opcode) + 32];
>      uint8_t r = Rrm(opcode);
>      uint8_t ex = Rc(opcode);
>      uint8_t rmc = RMC(opcode);

For future cleanup, it looks like the rounding mode should be passed in 
directly.

But anyway,

Reviewed-by: Richard Henderson <address@hidden>


r~