Re: [PATCH-for-9.1 03/21] target/i386: Move APIC related code to cpu-apic.c

[Philippe Mathieu-Daudé]

On 24/4/24 10:26, Zhao Liu wrote:
> On Thu, Mar 21, 2024 at 04:48:19PM +0100, Philippe Mathieu-Daudé wrote:
> > Date: Thu, 21 Mar 2024 16:48:19 +0100
> > From: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Subject: [PATCH-for-9.1 03/21] target/i386: Move APIC related code to
> >   cpu-apic.c
> > X-Mailer: git-send-email 2.41.0
> >
> > Move APIC related code split in cpu-sysemu.c and
> > monitor.c to cpu-apic.c.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   target/i386/cpu-apic.c   | 112 +++++++++++++++++++++++++++++++++++++++
> >   target/i386/cpu-sysemu.c |  77 ---------------------------
> >   target/i386/monitor.c    |  25 ---------
> >   target/i386/meson.build  |   1 +
> >   4 files changed, 113 insertions(+), 102 deletions(-)
> >   create mode 100644 target/i386/cpu-apic.c
> >
> > diff --git a/target/i386/cpu-apic.c b/target/i386/cpu-apic.c
> > new file mode 100644
> > index 0000000000..d397ec94dc
> > --- /dev/null
> > +++ b/target/i386/cpu-apic.c
>
> Nit: New file needs a MAINTAINER entry ;-).

Already covered here:

X86 general architecture support
M: Paolo Bonzini <pbonzini@redhat.com>
S: Maintained
F: configs/devices/i386-softmmu/default.mak
F: configs/targets/i386-softmmu.mak
F: configs/targets/x86_64-softmmu.mak
F: docs/system/target-i386*
F: target/i386/*.[ch]
               ^^^^^^
$ ./scripts/get_maintainer.pl -f target/i386/cpu-apic.c
Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86 general archi...)
qemu-devel@nongnu.org (open list:All patches CC here)

> Others LGTM,
>
> Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Thanks!