[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 05/33] accel/tcg: Cap the translation block when we encounter
From: |
Richard Henderson |
Subject: |
[PATCH v2 05/33] accel/tcg: Cap the translation block when we encounter mmio |
Date: |
Wed, 24 Apr 2024 16:31:03 -0700 |
Do not allow translation to proceed beyond one insn with mmio,
as we will not be caching the TranslationBlock.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/translator.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
index dbd54e25a2..c3f4d0e252 100644
--- a/accel/tcg/translator.c
+++ b/accel/tcg/translator.c
@@ -239,6 +239,8 @@ static bool translator_ld(CPUArchState *env,
DisasContextBase *db,
/* Use slow path if first page is MMIO. */
if (unlikely(tb_page_addr0(tb) == -1)) {
+ /* We capped translation with first page MMIO in tb_gen_code. */
+ tcg_debug_assert(db->max_insns == 1);
return false;
}
@@ -287,6 +289,8 @@ static bool translator_ld(CPUArchState *env,
DisasContextBase *db,
if (unlikely(new_page1 == -1)) {
tb_unlock_pages(tb);
tb_set_page_addr0(tb, -1);
+ /* Require that this be the final insn. */
+ db->max_insns = db->num_insns;
return false;
}
--
2.34.1
- [PATCH v2 00/33] accel/tcg: Improve disassembly for target and plugin, Richard Henderson, 2024/04/24
- [PATCH v2 02/33] accel/tcg: Hide in_same_page outside of a target-specific context, Richard Henderson, 2024/04/24
- [PATCH v2 01/33] accel/tcg: Use vaddr in translator_ld*, Richard Henderson, 2024/04/24
- [PATCH v2 03/33] accel/tcg: Pass DisasContextBase to translator_fake_ldb, Richard Henderson, 2024/04/24
- [PATCH v2 04/33] accel/tcg: Reorg translator_ld*, Richard Henderson, 2024/04/24
- [PATCH v2 11/33] plugins: Use translator_st for qemu_plugin_insn_data, Richard Henderson, 2024/04/24
- [PATCH v2 07/33] accel/tcg: Record when translator_fake_ldb is used, Richard Henderson, 2024/04/24
- [PATCH v2 05/33] accel/tcg: Cap the translation block when we encounter mmio,
Richard Henderson <=
- [PATCH v2 09/33] plugins: Copy memory in qemu_plugin_insn_data, Richard Henderson, 2024/04/24
- [PATCH v2 08/33] accel/tcg: Record DisasContextBase in tcg_ctx for plugins, Richard Henderson, 2024/04/24
- [PATCH v2 10/33] accel/tcg: Implement translator_st, Richard Henderson, 2024/04/24
- [PATCH v2 06/33] accel/tcg: Record mmio bytes during translation, Richard Henderson, 2024/04/24
- [PATCH v2 12/33] plugins: Read mem_only directly from TB cflags, Richard Henderson, 2024/04/24
- [PATCH v2 17/33] accel/tcg: Return bool from TranslatorOps.disas_log, Richard Henderson, 2024/04/24
- [PATCH v2 16/33] accel/tcg: Provide default implementation of disas_log, Richard Henderson, 2024/04/24