Re: [PATCH v3] Hexagon: add PC alignment check and exception

[Richard Henderson]

On 4/30/24 07:25, Matheus Tavares Bernardino wrote:
> The Hexagon Programmer's Reference Manual says that the exception 0x1e
> should be raised upon an unaligned program counter. Let's implement that
> and also add some tests.
>
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> ---
> v2: 
> e559b521d1920f804df10244c8c07564431aeba5.1714419461.git.quic_mathbern@quicinc.com/">https://lore.kernel.org/qemu-devel/e559b521d1920f804df10244c8c07564431aeba5.1714419461.git.quic_mathbern@quicinc.com/
>
> Thanks for the comments, Richard and Taylor!
>
> Changed in v3:
> - Removed now unnecessary pkt_raises_exception addition.
> - Added HEX_EXCP_PC_NOT_ALIGNED handling at
>    linux-user/hexagon/cpu_loop.c.
> - Merged all tests into a C file that uses signal handler to check
>    that the exception was raised.


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~