[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 49/58] vscsi: send the CHECK_CONDITION status down tog
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 49/58] vscsi: send the CHECK_CONDITION status down together with autosense data |
Date: |
Wed, 14 Sep 2011 10:43:13 +0200 |
From: Paolo Bonzini <address@hidden>
I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
2011-08-03) because at the time there was no way to expose a sense
condition to SLOF and Linux manages to work around the bug. However,
the bug becomes evident now that SCSI devices also report unit
attention on reset.
SLOF also has problems dealing with unit attention conditions, so
it still will not boot even with this fix (just like OpenBIOS).
IBM folks are aware of their part of the bug. :-)
Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
hw/spapr_vscsi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c
index 6fc82f6..e8426d7 100644
--- a/hw/spapr_vscsi.c
+++ b/hw/spapr_vscsi.c
@@ -483,7 +483,6 @@ static void vscsi_command_complete(SCSIRequest *sreq,
uint32_t status)
if (status == CHECK_CONDITION) {
req->senselen = scsi_req_get_sense(req->sreq, req->sense,
sizeof(req->sense));
- status = 0;
dprintf("VSCSI: Sense data, %d bytes:\n", len);
dprintf(" %02x %02x %02x %02x %02x %02x %02x %02x\n",
req->sense[0], req->sense[1], req->sense[2], req->sense[3],
--
1.6.0.2
- [Qemu-ppc] [PATCH 14/58] device tree: add nop_node, (continued)
- [Qemu-ppc] [PATCH 14/58] device tree: add nop_node, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 20/58] PPC: KVM: Remove kvmppc_read_host_property, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 32/58] PPC: Add new target config for pseries, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 25/58] PPC: E500: Update cpu-release-addr property in cpu nodes, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 46/58] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 23/58] PPC: E500: Remove unneeded CPU nodes, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 35/58] PPC: SPAPR: Use KVM function for time info, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 49/58] vscsi: send the CHECK_CONDITION status down together with autosense data,
Alexander Graf <=
- [Qemu-ppc] [PATCH 39/58] pseries: More complete WIMG validation in H_ENTER code, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 30/58] MPC8544DS: Generate CPU nodes on init, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 26/58] device tree: add add_subnode command, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 38/58] pseries: interrupt controller should not have a 'reg' property, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 33/58] KVM: update kernel headers, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 31/58] PPC: E500: Bump CPU count to 15, Alexander Graf, 2011/09/14