[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 28/58] device tree: give dt more size
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 28/58] device tree: give dt more size |
Date: |
Thu, 15 Sep 2011 13:19:32 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Sep 14, 2011 at 10:42:52AM +0200, Alexander Graf wrote:
> We currently load a device tree blob and then just take its size x2 to
> account for modifications we do inside. While this is nice and great,
> it fails when we have a small device tree as blob and lots of nodes added
> in machine init code.
>
> So for now, just make it 20k bigger than it was before. We maybe want to
> be more clever about this later.
In fact, one of the few things I can think of that might justify
qemu's "abstraction" of the libfdt interface, is that the wrappers
could be modified to detect -FDT_ERR_NOSPACE and realloc()
appropriately.
Otherwise the wrappers, which are limited and not notably simpler to
use than the raw libfdt functions seem pretty pointless to me.
Not that I'm biased as the author of libfdt or anything :).
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, (continued)
[Qemu-ppc] [PATCH 29/58] MPC8544DS: Remove CPU nodes, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 56/58] PPC: Fix via-cuda memory registration, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 06/58] PPC: Extend MPIC MMIO range, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 54/58] openpic: Unfold write_IRQreg, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 18/58] PPC: E500: Remove mpc8544_copy_soc_cell, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 07/58] PPC: Fix IPI support in MPIC, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 36/58] pseries: Bugfixes for interrupt numbering in XICS code, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 28/58] device tree: give dt more size, Alexander Graf, 2011/09/14
- Re: [Qemu-ppc] [PATCH 28/58] device tree: give dt more size,
David Gibson <=
[Qemu-ppc] [PATCH 34/58] PPC: Enable to use PAPR with PR style KVM, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 41/58] pseries: Add real mode debugging hcalls, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 17/58] PPC: E500: Use generic kvm function for freq, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 05/58] PPC: Add CPU local MMIO regions to MPIC, Alexander Graf, 2011/09/14