[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 08/20] target-ppc: Add hooks for handling tcg and
From: |
Andreas Färber |
Subject: |
Re: [Qemu-ppc] [PATCH 08/20] target-ppc: Add hooks for handling tcg and kvm limitations |
Date: |
Mon, 16 Apr 2012 12:19:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
Am 16.04.2012 12:13, schrieb Avi Kivity:
> On 04/15/2012 09:38 PM, Andreas Färber wrote:
>> From: David Gibson <address@hidden>
>>
>> On target-ppc, our table of CPU types and features encodes the features as
>> found on the hardware, regardless of whether these features are actually
>> usable under TCG or KVM. We already have cases where the information from
>> the cpu table must be fixed up to account for limitations in the emulation
>> method we're using. e.g. TCG does not support the DFP and VSX instructions
>> and KVM needs different numbering of the CPUs in order to tell it the
>> correct thread to core mappings.
>>
>> This patch cleans up these hacks to handle emulation limitations by
>> consolidating them into a pair of functions specifically for the purpose.
>>
>> env->check_pow = def->check_pow;
>> +
>> + if (kvm_enabled()) {
>> + if (kvmppc_fixup_cpu(env) != 0) {
>> + fprintf(stderr, "Unable to virtualize selected CPU with KVM\n");
>> + exit(1);
>> + }
>> + } else {
>> + if (ppc_fixup_cpu(env) != 0) {
>> + fprintf(stderr, "Unable to emulate selected CPU with TCG\n");
>> + exit(1);
>> + }
>> + }
>> +
>>
>
> I wish we had an error like that for x86. Right now we silently add and
> drop cpu features.
x86 has an ,+enforce option for that, doesn't it?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-ppc] [PATCH 04/20] pseries: Implement RTAS system-reboot call, (continued)
- [Qemu-ppc] [PATCH 04/20] pseries: Implement RTAS system-reboot call, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 05/20] pseries: Remove unused fields from VIOsPAPRBus structure, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 07/20] target-ppc: Drop cpu_ppc_close(), Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 11/20] target-ppc: QOM'ify CPU reset, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 09/20] target-ppc: QOM'ify CPU, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 12/20] target-ppc: Fix type casts for w64 (uintptr_t), Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 10/20] target-ppc: Start QOM'ifying CPU init, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 13/20] target-ppc: Init dcache and icache size for e500 user mode, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 08/20] target-ppc: Add hooks for handling tcg and kvm limitations, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 15/20] pseries: Fix RTAS based config access, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 17/20] pseries: Remove old hcalls hook stub, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 20/20] pseries: Fix reset of VIO network device, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 18/20] pseries: Correctly use the device model reset hooks, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 14/20] target-ppc/machine.c: Drop unnecessary ifdefs, Andreas Färber, 2012/04/15
- Re: [Qemu-ppc] [Qemu-devel] [PULL] ppc patch queue 2012-04-15, Andreas Färber, 2012/04/15
- Re: [Qemu-ppc] [PULL] ppc patch queue 2012-04-15, Blue Swirl, 2012/04/15
- [Qemu-ppc] [PATCH 02/20] pseries: Clean up hcall_dprintf() debugging messages, Andreas Färber, 2012/04/15
- [Qemu-ppc] [PATCH 06/20] pseries: Consolidate hack for RTAS display-character usage, Andreas Färber, 2012/04/15