[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR pl
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform. |
Date: |
Wed, 15 Aug 2012 09:02:18 +0200 |
On 15.08.2012, at 08:00, Li Zhang <address@hidden> wrote:
> On 2012年08月15日 02:09, Alexander Graf wrote:
>>
>> On 14.08.2012, at 19:49, Li Zhang <address@hidden> wrote:
>>
>>> USB is enabled as default on sPAPR platform because it needs
>>> USB keyboard and USB mouse when VGA is enabled.
>>>
>>> This patch is to add USB controller on sPAPR platform.
>>>
>>> Signed-off-by: Li Zhang <address@hidden>
>> This looks a lot better than the first version :).
> Thanks. :)
>>
>> Alex
>>
>>> ---
>>> hw/spapr.c | 5 +++++
>>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/spapr.c b/hw/spapr.c
>>> index 81c9343..b45401b 100644
>>> --- a/hw/spapr.c
>>> +++ b/hw/spapr.c
>>> @@ -710,6 +710,11 @@ static void ppc_spapr_init(ram_addr_t ram_size,
>>> spapr_vscsi_create(spapr->vio_bus);
>>> }
>>>
>>> + if (usb_enabled(true)) {
> Would you help replace "true" as "spapr->has_graphics" as your patch?
> We think it should be better to set the default as true when
> spapr->has_graphics.
> How do you think?
Yes, that's pretty much what I was asking for (here and for the mac99 u3
machine). Just base your patch on ppc-next. My patches are in there.
Alex
>>> + pci_create_simple(QLIST_FIRST(&spapr->phbs)->host_state.bus,
>>> + -1, "pci-ohci");
>>> + }
>>> +
>>> if (rma_size < (MIN_RMA_SLOF << 20)) {
>>> fprintf(stderr, "qemu: pSeries SLOF firmware requires >= "
>>> "%ldM guest RMA (Real Mode Area memory)\n", MIN_RMA_SLOF);
>>> --
>>> 1.7.7.6
>>>
>
>
> --
>
> Li Zhang
> IBM China Linux Technology Centre
>
- [Qemu-ppc] [Qemu-devel][PATCH v8 1/2] Add USB option in machine options, Li Zhang, 2012/08/14
- [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., Li Zhang, 2012/08/14
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., Alexander Graf, 2012/08/14
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., Li Zhang, 2012/08/15
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform.,
Alexander Graf <=
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., Li Zhang, 2012/08/15
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., Benjamin Herrenschmidt, 2012/08/15
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., David Gibson, 2012/08/15
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., Li Zhang, 2012/08/15
- Re: [Qemu-ppc] [Qemu-devel][PATCH v8 2/2] Add USB enablement on sPAPR platform., Li Zhang, 2012/08/15
Re: [Qemu-ppc] [Qemu-devel][PATCH v8 1/2] Add USB option in machine options, Alexander Graf, 2012/08/14