[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 6/7] pseries: Fix some small errors in XICS logic
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PATCH 6/7] pseries: Fix some small errors in XICS logic |
Date: |
Mon, 8 Apr 2013 15:08:21 +1000 |
Under certain circumstances the emulation for the pseries "XICS" interrupt
controller was clearing a pending interrupt from the XISR register, without
also clearing the corresponding priority variable. This will cause
problems later when can trigger sanity checks in the under-development
in-kernel XICS implementation.
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/xics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/xics.c b/hw/ppc/xics.c
index 374da5b..207691b 100644
--- a/hw/ppc/xics.c
+++ b/hw/ppc/xics.c
@@ -101,6 +101,7 @@ static void icp_set_cppr(struct icp_state *icp, int server,
uint8_t cppr)
if (XISR(ss) && (cppr <= ss->pending_priority)) {
old_xisr = XISR(ss);
ss->xirr &= ~XISR_MASK; /* Clear XISR */
+ ss->pending_priority = 0xff;
qemu_irq_lower(ss->output);
ics_reject(icp->ics, old_xisr);
}
@@ -127,6 +128,7 @@ static uint32_t icp_accept(struct icp_server_state *ss)
qemu_irq_lower(ss->output);
ss->xirr = ss->pending_priority << 24;
+ ss->pending_priority = 0xff;
trace_xics_icp_accept(xirr, ss->xirr);
--
1.7.10.4
- [Qemu-ppc] [0/7] Pending pseries updates, David Gibson, 2013/04/08
- [Qemu-ppc] [PATCH 3/7] pseries: Fix incorrect calculation of RMA size in certain configurations, David Gibson, 2013/04/08
- [Qemu-ppc] [PATCH 2/7] pseries: Generate device paths for VIO devices, David Gibson, 2013/04/08
- [Qemu-ppc] [PATCH 4/7] pseries: Fixes and enhancements to L1 cache properties, David Gibson, 2013/04/08
- [Qemu-ppc] [PATCH 5/7] target-ppc: Add more stubs for POWER7 PMU registers, David Gibson, 2013/04/08
- [Qemu-ppc] [PATCH 6/7] pseries: Fix some small errors in XICS logic,
David Gibson <=
- [Qemu-ppc] [PATCH 7/7] target-ppc: Synchronize VPA state with KVM, David Gibson, 2013/04/08
- [Qemu-ppc] [PATCH 1/7] pseries: Convert VIO code to QOM style type safe(ish) casts, David Gibson, 2013/04/08
- Re: [Qemu-ppc] [0/7] Pending pseries updates, Alexander Graf, 2013/04/19